In /logs/firmware/unblob_extracted/firmware_extract/DIR-600_fw_revb5_214b01_ALL_de_20130122/dir600b_v2.14_d1mg.bin_extract/1179788-3612812.squashfs_v4_le_extract/etc/events/checkfw.sh line 4:
odel="`xmldbc -g /runtime/device/modelname`"
^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
Did you mean:
model="$(xmldbc -g /runtime/device/modelname)"
In /logs/firmware/unblob_extracted/firmware_extract/DIR-600_fw_revb5_214b01_ALL_de_20130122/dir600b_v2.14_d1mg.bin_extract/1179788-3612812.squashfs_v4_le_extract/etc/events/checkfw.sh line 7:
old_major=`cat /etc/config/buildver|cut -d'.' -f1`
^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
Did you mean:
old_major=$(cat /etc/config/buildver|cut -d'.' -f1)
In /logs/firmware/unblob_extracted/firmware_extract/DIR-600_fw_revb5_214b01_ALL_de_20130122/dir600b_v2.14_d1mg.bin_extract/1179788-3612812.squashfs_v4_le_extract/etc/events/checkfw.sh line 8:
old_minor=`cat /etc/config/buildver|cut -d'.' -f2|cut -c1-2`
^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
Did you mean:
old_minor=$(cat /etc/config/buildver|cut -d'.' -f2|cut -c1-2)
In /logs/firmware/unblob_extracted/firmware_extract/DIR-600_fw_revb5_214b01_ALL_de_20130122/dir600b_v2.14_d1mg.bin_extract/1179788-3612812.squashfs_v4_le_extract/etc/events/checkfw.sh line 22:
`tcprequest "$reqstr" "$srv" 80 -f "$fwinfo" -t 5 -s`
^-- SC2092 (warning): Remove backticks to avoid executing output (or use eval if intentional).
^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
Did you mean:
$(tcprequest "$reqstr" "$srv" 80 -f "$fwinfo" -t 5 -s)
In /logs/firmware/unblob_extracted/firmware_extract/DIR-600_fw_revb5_214b01_ALL_de_20130122/dir600b_v2.14_d1mg.bin_extract/1179788-3612812.squashfs_v4_le_extract/etc/events/checkfw.sh line 25:
new_major=`grep Major /tmp/fwinfo.xml |sed 's/^[ \t]*//'|sed 's/<Major>//'|sed 's/<\/Major>//'`
^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
Did you mean:
new_major=$(grep Major /tmp/fwinfo.xml |sed 's/^[ \t]*//'|sed 's/<Major>//'|sed 's/<\/Major>//')
In /logs/firmware/unblob_extracted/firmware_extract/DIR-600_fw_revb5_214b01_ALL_de_20130122/dir600b_v2.14_d1mg.bin_extract/1179788-3612812.squashfs_v4_le_extract/etc/events/checkfw.sh line 26:
new_minor=`grep Minor /tmp/fwinfo.xml |sed 's/^[ \t]*//'|sed 's/<Minor>//'|sed 's/<\/Minor>//'`
^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
Did you mean:
new_minor=$(grep Minor /tmp/fwinfo.xml |sed 's/^[ \t]*//'|sed 's/<Minor>//'|sed 's/<\/Minor>//')
In /logs/firmware/unblob_extracted/firmware_extract/DIR-600_fw_revb5_214b01_ALL_de_20130122/dir600b_v2.14_d1mg.bin_extract/1179788-3612812.squashfs_v4_le_extract/etc/events/checkfw.sh line 28:
xmldbc -s /runtime/firmware/fwversion/Major $new_major
^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
xmldbc -s /runtime/firmware/fwversion/Major "$new_major"
In /logs/firmware/unblob_extracted/firmware_extract/DIR-600_fw_revb5_214b01_ALL_de_20130122/dir600b_v2.14_d1mg.bin_extract/1179788-3612812.squashfs_v4_le_extract/etc/events/checkfw.sh line 29:
xmldbc -s /runtime/firmware/fwversion/Minor $new_minor
^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
xmldbc -s /runtime/firmware/fwversion/Minor "$new_minor"
In /logs/firmware/unblob_extracted/firmware_extract/DIR-600_fw_revb5_214b01_ALL_de_20130122/dir600b_v2.14_d1mg.bin_extract/1179788-3612812.squashfs_v4_le_extract/etc/events/checkfw.sh line 33:
if [ $new_major -gt $old_major -o $new_major -eq $old_major -a $new_minor -gt $old_minor ]; then
^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-- SC2166 (warning): Prefer [ p ] || [ q ] as [ p -o q ] is not well defined.
^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-- SC2166 (warning): Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ "$new_major" -gt "$old_major" -o "$new_major" -eq "$old_major" -a "$new_minor" -gt "$old_minor" ]; then
For more information:
https://www.shellcheck.net/wiki/SC2092 -- Remove backticks to avoid executi...
https://www.shellcheck.net/wiki/SC2166 -- Prefer [ p ] && [ q ] as [ p -a q...
https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
[*] Source file checkfw.sh
